wzj/dify-1.72
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: goto-anything command filter should only match shortcut (#23862)

Browse Source
This commit is contained in:
lyzno1 2025-08-13 13:55:25 +08:00 committed by GitHub
parent e11a334c9b
commit e0fe0e1a3e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
web/__tests__/goto-anything/command-selector.test.tsx
View File

@ -37,7 +37,7 @@ describe('CommandSelector', () => {
}, },
knowledge: { knowledge: {
key: '@knowledge', key: '@knowledge',
shortcut: '@knowledge', shortcut: '@kb',
title: 'Search Knowledge', title: 'Search Knowledge',
description: 'Search knowledge bases', description: 'Search knowledge bases',
search: jest.fn(), search: jest.fn(),
@ -75,7 +75,7 @@ describe('CommandSelector', () => {
) )
expect(screen.getByTestId('command-item-@app')).toBeInTheDocument() expect(screen.getByTestId('command-item-@app')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@knowledge')).toBeInTheDocument() expect(screen.getByTestId('command-item-@kb')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument() expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@node')).toBeInTheDocument() expect(screen.getByTestId('command-item-@node')).toBeInTheDocument()
}) })
@ -90,7 +90,7 @@ describe('CommandSelector', () => {
) )
expect(screen.getByTestId('command-item-@app')).toBeInTheDocument() expect(screen.getByTestId('command-item-@app')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@knowledge')).toBeInTheDocument() expect(screen.getByTestId('command-item-@kb')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument() expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@node')).toBeInTheDocument() expect(screen.getByTestId('command-item-@node')).toBeInTheDocument()
}) })
@ -107,7 +107,7 @@ describe('CommandSelector', () => {
) )
expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument()
expect(screen.getByTestId('command-item-@knowledge')).toBeInTheDocument() expect(screen.getByTestId('command-item-@kb')).toBeInTheDocument()
expect(screen.queryByTestId('command-item-@plugin')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@plugin')).not.toBeInTheDocument()
expect(screen.queryByTestId('command-item-@node')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@node')).not.toBeInTheDocument()
}) })
@ -122,7 +122,7 @@ describe('CommandSelector', () => {
) )
expect(screen.getByTestId('command-item-@app')).toBeInTheDocument() expect(screen.getByTestId('command-item-@app')).toBeInTheDocument()
expect(screen.queryByTestId('command-item-@knowledge')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@kb')).not.toBeInTheDocument()
expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument() expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument()
expect(screen.queryByTestId('command-item-@node')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@node')).not.toBeInTheDocument()
}) })
@ -137,7 +137,7 @@ describe('CommandSelector', () => {
) )
expect(screen.getByTestId('command-item-@app')).toBeInTheDocument() expect(screen.getByTestId('command-item-@app')).toBeInTheDocument()
expect(screen.queryByTestId('command-item-@knowledge')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@kb')).not.toBeInTheDocument()
}) })
it('should match partial strings', () => { it('should match partial strings', () => {
@ -145,14 +145,14 @@ describe('CommandSelector', () => {
<CommandSelector <CommandSelector
actions={mockActions} actions={mockActions}
onCommandSelect={mockOnCommandSelect} onCommandSelect={mockOnCommandSelect}
searchFilter="nowl" searchFilter="od"
/>, />,
) )
expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument()
expect(screen.getByTestId('command-item-@knowledge')).toBeInTheDocument() expect(screen.queryByTestId('command-item-@kb')).not.toBeInTheDocument()
expect(screen.queryByTestId('command-item-@plugin')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@plugin')).not.toBeInTheDocument()
expect(screen.queryByTestId('command-item-@node')).not.toBeInTheDocument() expect(screen.getByTestId('command-item-@node')).toBeInTheDocument()
}) })
}) })
@ -167,7 +167,7 @@ describe('CommandSelector', () => {
) )
expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument()
expect(screen.queryByTestId('command-item-@knowledge')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@kb')).not.toBeInTheDocument()
expect(screen.queryByTestId('command-item-@plugin')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@plugin')).not.toBeInTheDocument()
expect(screen.queryByTestId('command-item-@node')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@node')).not.toBeInTheDocument()
@ -210,7 +210,7 @@ describe('CommandSelector', () => {
/>, />,
) )
expect(mockOnCommandValueChange).toHaveBeenCalledWith('@knowledge') expect(mockOnCommandValueChange).toHaveBeenCalledWith('@kb')
}) })
it('should not call onCommandValueChange if current value still exists', () => { it('should not call onCommandValueChange if current value still exists', () => {
@ -246,10 +246,10 @@ describe('CommandSelector', () => {
/>, />,
) )
const knowledgeItem = screen.getByTestId('command-item-@knowledge') const knowledgeItem = screen.getByTestId('command-item-@kb')
fireEvent.click(knowledgeItem) fireEvent.click(knowledgeItem)
expect(mockOnCommandSelect).toHaveBeenCalledWith('@knowledge') expect(mockOnCommandSelect).toHaveBeenCalledWith('@kb')
}) })
}) })
@ -276,7 +276,7 @@ describe('CommandSelector', () => {
) )
expect(screen.getByTestId('command-item-@app')).toBeInTheDocument() expect(screen.getByTestId('command-item-@app')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@knowledge')).toBeInTheDocument() expect(screen.getByTestId('command-item-@kb')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument() expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@node')).toBeInTheDocument() expect(screen.getByTestId('command-item-@node')).toBeInTheDocument()
}) })
@ -312,7 +312,7 @@ describe('CommandSelector', () => {
) )
expect(screen.getByTestId('command-item-@app')).toBeInTheDocument() expect(screen.getByTestId('command-item-@app')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@knowledge')).toBeInTheDocument() expect(screen.getByTestId('command-item-@kb')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument() expect(screen.getByTestId('command-item-@plugin')).toBeInTheDocument()
expect(screen.getByTestId('command-item-@node')).toBeInTheDocument() expect(screen.getByTestId('command-item-@node')).toBeInTheDocument()
}) })
@ -326,7 +326,7 @@ describe('CommandSelector', () => {
/>, />,
) )
expect(screen.getByTestId('command-item-@knowledge')).toBeInTheDocument() expect(screen.getByTestId('command-item-@kb')).toBeInTheDocument()
expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument() expect(screen.queryByTestId('command-item-@app')).not.toBeInTheDocument()
}) })
}) })

1
web/app/components/goto-anything/command-selector.tsx
View File

@ -20,7 +20,6 @@ const CommandSelector: FC<Props> = ({ actions, onCommandSelect, searchFilter, co
return true return true
const filterLower = searchFilter.toLowerCase() const filterLower = searchFilter.toLowerCase()
return action.shortcut.toLowerCase().includes(filterLower) return action.shortcut.toLowerCase().includes(filterLower)
|| action.key.toLowerCase().includes(filterLower)
}) })
useEffect(() => { useEffect(() => {